Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop urllib3 upper bound #2131

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Drop urllib3 upper bound #2131

merged 1 commit into from
Oct 4, 2023

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Oct 4, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This bound was added in 27459d5.

Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389

(I'm also not sure that I follow the logic in #2105, since dependency resolvers would have been able to work out a compatible set of packages based on google-auth's dependencies without propagating the bound into this project)

Which issue(s) this PR fixes:

Fixes #2129

Does this PR introduce a user-facing change?

NONE

@hauntsaninja
Drop urllib3 upper bound
af68284 
This was added in kubernetes-client@27459d5.

Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389

(I'm also not sure that I follow the logic in kubernetes-client#2105, since dependency resolvers will be able to work it out)
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 4, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hauntsaninja / name: Shantanu (af68284)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @hauntsaninja!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 4, 2023
@yliaog
Copy link
Contributor

yliaog commented Oct 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hauntsaninja, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit d5d835a into kubernetes-client:master Oct 4, 2023
10 checks passed
@LanceEa LanceEa mentioned this pull request Oct 9, 2023
Merged
6 tasks
@ralgozino ralgozino mentioned this pull request Oct 9, 2023
Closed
@ingvaldlorentzen
Copy link

Could we get a release with this change? Would solve a lot of dependency resolving issues

@shuoli84 shuoli84 mentioned this pull request Nov 25, 2023
Closed
dirrao pushed a commit to dirrao/python that referenced this pull request Nov 28, 2023
@k8s-ci-robot
Merge pull request kubernetes-client#2131 from hauntsaninja/patch-1
193e1b0 
Drop urllib3 upper bound
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Dec 9, 2023
@hswong3i
alvistack/v28.1.0
c8886ea 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_28.1.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_28.1.0-1.spec
    cp ../python*-kubernetes*28.1.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-28.1.0/
    rm -rf ../python*-kubernetes_28.1.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@tiraboschi tiraboschi mentioned this pull request Dec 19, 2023
Merged
11 tasks
tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Dec 19, 2023
@tiraboschi
[k8s-label-visualiz] bump client-python pip3 dep
b092c3b 
Bump Kubernetes Python Client pip3 dependency
to v29.0.0 Alpha 1 Release
to consume kubernetes-client/python#2131
in order to get a fix for a conflict with recent
urllib3

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit to kubevirt/hyperconverged-cluster-operator that referenced this pull request Dec 19, 2023
@tiraboschi
[k8s-label-visualiz] bump client-python pip3 dep (#2688)
1cbe612 
Bump Kubernetes Python Client pip3 dependency
to v29.0.0 Alpha 1 Release
to consume kubernetes-client/python#2131
in order to get a fix for a conflict with recent
urllib3

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@hauntsaninja hauntsaninja deleted the patch-1 branch December 31, 2023 10:22
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Jan 9, 2024
@hswong3i
alvistack/v28.1.0
d9ae03e 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_28.1.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_28.1.0-1.spec
    cp ../python*-kubernetes*28.1.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-28.1.0/
    rm -rf ../python*-kubernetes_28.1.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Jan 9, 2024
@hswong3i
alvistack/v29.0.0
11c1a68 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_29.0.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_29.0.0-1.spec
    cp ../python*-kubernetes*29.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-29.0.0/
    rm -rf ../python*-kubernetes_29.0.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Feb 6, 2024
@hswong3i
alvistack/v28.1.0
72abe90 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_28.1.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_28.1.0-1.spec
    cp ../python*-kubernetes*28.1.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-28.1.0/
    rm -rf ../python*-kubernetes_28.1.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Feb 6, 2024
@hswong3i
alvistack/v29.0.0
1adba43 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_29.0.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_29.0.0-1.spec
    cp ../python*-kubernetes*29.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-29.0.0/
    rm -rf ../python*-kubernetes_29.0.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Feb 25, 2024
@hswong3i
alvistack/v28.1.0
f077711 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_28.1.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_28.1.0-1.spec
    cp ../python*-kubernetes*28.1.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-28.1.0/
    rm -rf ../python*-kubernetes_28.1.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-client-python that referenced this pull request Feb 25, 2024
@hswong3i
alvistack/v29.0.0
7a2086b 
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    tar zcvf ../python-kubernetes_29.0.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-kubernetes.spec ../python-kubernetes_29.0.0-1.spec
    cp ../python*-kubernetes*29.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-client-python-29.0.0/
    rm -rf ../python*-kubernetes_29.0.0*.*

See kubernetes-client#2131

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow both urllib3 1 and urllib3 2 in the kubernetes python package
4 participants
@hauntsaninja @k8s-ci-robot @yliaog @ingvaldlorentzen