Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: update local execution limitations #3736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sdk: update local execution limitations #3736

wants to merge 1 commit into from

Conversation

connor-mccarthy
Copy link
Member

No description provided.

@connor-mccarthy
Copy link
Member Author

/assign @chensun

sen-sam
sen-sam suggested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@sen-sam sen-sam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. Mostly LGTM.

@connor-mccarthy connor-mccarthy force-pushed the add-local-execution-limitation branch 2 times, most recently from 1825253 to 1f653f5 Compare May 17, 2024 22:53
sen-sam
sen-sam approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@sen-sam sen-sam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider changing "you need to" to "you must" in a future PR.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sen-sam
Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
local execution limitation
3c2a950 
Signed-off-by: connor-mccarthy <mccarthy.connor.james@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sen-sam sen-sam sen-sam approved these changes

@alfsuse alfsuse Awaiting requested review from alfsuse

@joeliedtke joeliedtke Awaiting requested review from joeliedtke

Assignees

@chensun chensun

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@connor-mccarthy @sen-sam @chensun