Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update the document of Feast feature store. #3734

Merged
merged 1 commit into from
May 23, 2024

Conversation

shuchu
Copy link
Contributor

@shuchu shuchu commented May 10, 2024

  • Update the obsoleted links
  • Remove one line about upgrading Feast from 0.9 to 0.12. The version numbers are too old. The latest version is 0.37.1.

Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Copy link

Hi @shuchu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shuchu I just don't see this change:

Remove one line about upgrading Feast from 0.9 to 0.12. The version numbers are too old. The latest version is 0.37.1.

@shuchu
Copy link
Contributor Author

shuchu commented May 10, 2024

/lgtm

@shuchu I just don't see this change:

Remove one line about upgrading Feast from 0.9 to 0.12. The version numbers are too old. The latest version is 0.37.1.

hi @hbelmiro I removed the Line 33 :)

@hbelmiro
Copy link
Contributor

@shuchu

hi @hbelmiro I removed the Line 33 :)

Oh, man. I think I'm getting blind 🥲

@shuchu
Copy link
Contributor Author

shuchu commented May 22, 2024

its been a while, is it good to merge now? :)

@hbelmiro
Copy link
Contributor

@andreyvelich can we get this merged?

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.
/assign @franciscojavierarceo to review FEAST changes.

Copy link
Contributor

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for this @shuchu!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@franciscojavierarceo
Copy link
Contributor

/approve

@google-oss-prow google-oss-prow bot merged commit 9bb47dd into kubeflow:master May 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants