Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more compatible URL concat way #3704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

realnumber666
Copy link

@realnumber666 realnumber666 commented Mar 27, 2024

Fixes #3703 , I try to use urljoin in urllib package to provide a more compatible URL concat way in KFP quickstart doc.

Signed-off-by: Xinyu Wu <realnumber666@gmail.com>
Copy link

google-cla bot commented Mar 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hi @realnumber666. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: realnumber666
Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@hbelmiro
Copy link
Contributor

hbelmiro commented Apr 3, 2024

Thank you for this contribution @realnumber666.
/lgtm

@hbelmiro
Copy link
Contributor

hbelmiro commented Apr 3, 2024

@realnumber666 can you please edit the PR description to use Fixes https://github.com/kubeflow/website/issues/3703 instead of Based on my issue https://github.com/kubeflow/website/issues/3703. That way GitHub will automatically link this PR to your issue and will automatically close the issue when this PR is closed.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Thank you in advance.

@realnumber666
Copy link
Author

@hbelmiro Done. Thanks for your advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A more compatible way for concat a url in Kubeflow Pipeline/v2/Installation/Quickstart
3 participants