-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to RStudio #3608
Link to RStudio #3608
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @nathanweeks. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Ping if this PR might receive "approved, lgtm labels". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@thesuperzapper can you PTAL?
/hold for DCO @nathanweeks can you please sign off your commits |
/check-dco |
@hbelmiro sadly we don't currently use the DCO plugin for prow (we are planning to move to it), but we currently use the GitHub DCO bot (which will only recheck this PR if it has a push). Either way, weshould probably close this very old PR, and make a new one. |
Signed-off-by: Nathan Weeks <1800812+nathanweeks@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@thesuperzapper can you please take a second look? @nathanweeks fixed DCO.
@nathanweeks thanks for this, sorry for the crazy delay! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Make RStudio link point to https://github.com/rstudio/rstudio (instead of https://github.com/jupyterlab/jupyterlab) for consistency with:
website/content/en/docs/components/notebooks/container-images.md
Line 7 in f88fcc0