Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to RStudio #3608

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Link to RStudio #3608

merged 1 commit into from
Jun 2, 2024

Conversation

nathanweeks
Copy link
Contributor

Make RStudio link point to https://github.com/rstudio/rstudio (instead of https://github.com/jupyterlab/jupyterlab) for consistency with:

Kubeflow Notebooks natively supports three types of notebooks, [JupyterLab](https://github.com/jupyterlab/jupyterlab), [RStudio](https://github.com/rstudio/rstudio), and [Visual Studio Code (code-server)](https://github.com/cdr/code-server), but any web-based IDE should work.

@google-cla
Copy link

google-cla bot commented Oct 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

Hi @nathanweeks. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@nathanweeks
Copy link
Contributor Author

Ping if this PR might receive "approved, lgtm labels".

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thesuperzapper can you PTAL?

@hbelmiro
Copy link
Contributor

/hold for DCO

@nathanweeks can you please sign off your commits

@hbelmiro
Copy link
Contributor

/check-dco

@thesuperzapper
Copy link
Member

@hbelmiro sadly we don't currently use the DCO plugin for prow (we are planning to move to it), but we currently use the GitHub DCO bot (which will only recheck this PR if it has a push).

Either way, weshould probably close this very old PR, and make a new one.

Signed-off-by: Nathan Weeks <1800812+nathanweeks@users.noreply.github.com>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thesuperzapper can you please take a second look? @nathanweeks fixed DCO.

@google-oss-prow google-oss-prow bot added the lgtm label May 31, 2024
@thesuperzapper
Copy link
Member

@nathanweeks thanks for this, sorry for the crazy delay!

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

/unhold

@google-oss-prow google-oss-prow bot merged commit 76dab7b into kubeflow:master Jun 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants