Add restartPolicy field to SparkApplication Driver/Executor initContainers CRDs #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Schroering <mark.schroering@gmail.com>
Signed-off-by: Mark Schroering <mark.schroering@gmail.com>
Signed-off-by: Mark Schroering <mark.schroering@gmail.com>
|
+1 this will be very helpful. |
|
+1 as well, we could use this |
|
Good feature, would love to use it for our logging sidecar |
vara-bonthu
approved these changes
May 29, 2024
|
/assign mwielgus |
|
/assign yuchaoran2011 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
InitContainers can now specify a
restartPolicywith a value ofAlwaysto make the init container act like a sidecar. This PR updates the CRDs to allow this field to be present.https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#lifecycle
https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
Proposed changes:
restartPolicytodriver.initContainersandexecutor.initContainersfor bothSparkApplicationandScheduledSparkApplication.Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
This allows users of the helm chart to set
restartPolicy: "Always"for init containers on the executor and driver pods.Checklist
Before submitting your PR, please review the following: