Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exposing extra TCP ports in Spark Driver via K8s Ingress #1998

Merged
merged 6 commits into from
May 20, 2024

Conversation

hiboyang
Copy link
Contributor

Purpose of this PR

See #1984: Support exposing extra TCP ports in Spark Driver via K8s Ingress

Proposed changes:

  • Add driverIngressOptions in Spark application CRD to specify parameters for extra ingress
  • Refactor Spark UI options related code to reuse code between spark UI and spark driver ingress
  • Add unit test for spark driver ingress

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • [ x] Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

This is to support some use cases like exposing Spark Connect server side port in Driver to network traffic outside of the K8s cluster. Another use case is to run Jupyter Notebook Server or Kernel Gateway inside Spark Driver, so user could use Jupyter Notebook within the Spark application.

Checklist

Before submitting your PR, please review the following:

  • [ x] I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • [ x] I have added tests that prove my changes are effective or that my feature works.
  • [ x] Existing unit tests pass locally with my changes.

Additional Notes

N/A

@hiboyang hiboyang marked this pull request as draft April 19, 2024 19:27
@hiboyang hiboyang force-pushed the bo-dev-01 branch 3 times, most recently from 824eebd to 1580426 Compare May 20, 2024 16:53
@hiboyang hiboyang changed the title [DRAFT] Support exposing extra TCP ports in Spark Driver via K8s Ingress Support exposing extra TCP ports in Spark Driver via K8s Ingress May 20, 2024
@hiboyang hiboyang marked this pull request as ready for review May 20, 2024 16:56
@google-oss-prow google-oss-prow bot requested a review from mwielgus May 20, 2024 16:56
Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
@yuchaoran2011
Copy link
Contributor

/lgtm

Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
@google-oss-prow google-oss-prow bot removed the lgtm label May 20, 2024
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added lgtm and removed lgtm labels May 20, 2024
Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
Signed-off-by: Bo (AIML) Yang <bo_yang6@apple.com>
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 20, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b723367 into kubeflow:master May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants