Expose Prometheus port when custom config files are used

[suryadutta]

Note

This is almost a duplicate of this PR: #1165
I'm opening this because that PR was abandoned (was opened by a former employee at my company, SpotHero)

---

Right now, the patch that adds the Prometheus container port when Prometheus is enabled does not run if these two configurations are provided in the spec:

• SparkApplication.spec.monitoring.metricsPropertiesFile (link to docs)
• SparkApplication.spec.monitoring.prometheus.configFile (link to docs)

This leads to an issue where the jmx-exporter port doesn't get exposed in either driver or executor containers if both of these configurations are set. More details here: #1053

---

The current behavior of the code is as follows:

If prometheus is enabled AND both metricsPropertiesFile and prometheus.configFile are not set:

1. create a patch to create the Prometheus container port
2. create a patch to create the VolumeMount at config.PrometheusConfigMapMountPath

However, only the second patch (VolumeMount) needs to be skipped if both metricsPropertiesFile and prometheus.configFile are set, since the default configs won't be mounted there.

This PR proposes modifying the logic to reflect this correct state.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[suryadutta]

HI @liyinan926. Can you help review this PR?

Thank you!

[suryadutta]

@liyinan926 - this PR is still waiting for a review.

If this project is no longer actively maintained, could you let the community know? I think this project is still being actively used by a large group of people/companies.

[liyinan926]

@suryadutta Thanks for the PR. I have not been able to do much for this repo in the past couple of years. We are trying to figure out what to do for this repo at this point.

[suryadutta]

@suryadutta Thanks for the PR. I have not been able to do much for this repo in the past couple of years. We are trying to figure out what to do for this repo at this point.

@liyinan926 Totally understand, appreciate the response!