fix(backend): fixes upload pipeline version function. Fixes #10825

[rchojn]

Introduce fix to upload_pipeline_version function - removed unnecessary all condition.

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-oss-prow]

Hi @rchojn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hbelmiro]

/ok-to-test

[rchojn]

/retest

[rchojn]

@hbelmiro is there a way to see a detailed log of this error?

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• sdk/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chensun]

The all checks ensures that pipeline_id and pipeline_name aren't provided at the same time--either you upload a brand new pipeline so you need to provide a name or you upload to an existing pipeline as a new version so you need to specify the id.

[rchojn]

@chensun, thanks for the clarification. Here's how the pipeline lifecycle works from my perspective:

1. I upload the pipeline with a specific name using the command:

   kfp pipeline create -p pipeline123 package.yaml
   

2. After releasing new code, I want to upload a new version of the pipeline. To do this, I follow these steps:

   a) I attempt to create a new version using:

   kfp pipeline create-version -n pipeline123 -v 2024-05-23 package.yaml
   

   However, this shows the error: Either pipeline_id or pipeline_name is required. This is misleading because the pipeline_name was provided. Why is the pipeline_name option not available here? Isn't this a potential issue or at least something that needs clarification?

   b) I then use the command:

   kfp pipeline create-version -p 20540d8f-03f0-4ec2-97d1-3b79d341d713 -v 2024-05-23 package.yaml
   

   This works as expected. So, it appears I need to store the pipeline_id or obtain it dynamically before deploying the new pipeline version. It seems I can't rely solely on the pipeline_name.

Could you please provide some clarification on why the pipeline_name option isn't supported for creating a new version and if there's a recommended way to handle this?

Thank you.

---

[rchojn]

@chensun so I believe, there is no need to fetch additionally pipeline_id in create_version command. Because of this mechanism, we get both pipeline_id and pipeline_name which then are passed to upload_pipeline_version and it ended up with mentioned error

[rchojn]

@connor-mccarthy could you please have a look?

[rchojn]

/retest-required

[google-oss-prow]

@rchojn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kubeflow-pipelines-sdk-execution-tests	63fc540	link	true	/test kubeflow-pipelines-sdk-execution-tests
kfp-kubernetes-execution-tests	63fc540	link	false	/test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.