Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-red examples to /contrib #2723

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

sefgsefg
Copy link

We made two examples that using Node-red to control kubeflow pipeline

We use Node-red to create a user interface that allows users to select pipeline execution parameters through node settings. The process includes program code execution, YAML file compilation, automatic pipeline file upload, and data return, reducing user operation time.

Of course, users can also create their own Node-red interface through sample templates to meet their needs.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout changed the title Add some example in contrib Add node-red examples to /contrib May 21, 2024
@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 21, 2024

Hello, you need to sign the DCO and rebase to master.

Before merging this, we first need to get actual node-red manifests or platform stuff, because this is the manifests/platform repository. As explained in the manifests WG meetings we need something similar to the Kserve or Ray integration.

https://github.com/kubeflow/manifests/tree/master/contrib/kserve there is UI integration and Kustomize stuff with Kubernetes deployments etc.

Furthermore, where is all of this coming from? What is your organizations base repository?

CC @kimwnasptd @rimolive @andreyvelich

@sefgsefg
Copy link
Author

I have sign-off the DCO but it still get error. Is there any problem I don't solve?

@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 22, 2024

I have sign-off the DCO but it still get error. Is there any problem I don't solve?

Please take a look at the output of the DCO check https://github.com/kubeflow/manifests/pull/2723/checks?check_run_id=25255505195 by clicking on the details button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants