Create PR template #2722
Merged
Create PR template #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
…emplate create PR template
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
…emplate Feature pull request template
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
…emplate create PR template
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
…emplate make changes to PR template folder
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,33 @@ | |||
| # Pull Request Template related to Kubeflow manifests Issues | |||
|
|
|||
| 🔄 Please include a summary of changes and the related issue. List any dependencies that are required for this change. Please delete the options that are not relevant. | |||
There was a problem hiding this comment.
Can we itemize that?
Tasks for a proper PR that can be reviewed by the maintainers:
- Include a summary of changes and the related issue
- List any dependencies that are required for this change
- Delete the options that are not relevant.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| > I changed ... | ||
|
|
||
| ## 📦 List any dependencies that are required for this change | ||
| > depend on # |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| > depend on # | ||
|
|
||
| ## 🐛 If this PR is related to an issue, please put the link of the issue here. | ||
| > link to issue # |
There was a problem hiding this comment.
The following issues are related, because ...
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| --- | ||
|
|
||
| >You can join our slack channel [wg-manifests](https://www.kubeflow.org/docs/about/community/) here. This link also contains our meeting schedule. |
There was a problem hiding this comment.
slack channel wg-manifests here.
hansinikarunarathne
force-pushed
the
master
branch
from
f81b8a9
to
8d250c8
Compare
Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
hansinikarunarathne
force-pushed
the
master
branch
from
8d250c8
to
75bf4f2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
biswajit-9776
pushed a commit
to biswajit-9776/manifests
that referenced
this pull request
May 29, 2024
* Add issue report template Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Add config.yaml Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Adderessing the requested changes Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * create PR template Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> * create PR template Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> * create PR template Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> * create PR template Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> * make changes to PR template folder Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> * Address the requested changes Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk> --------- Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> Signed-off-by: Hansini Karunarathne <hansini.20@cse.mrt.ac.lk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new PR template for the Kubeflow manifest repo