Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/spf13/viper from 1.10.0 to 1.18.2 #1018

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Dec 19, 2023

Bumps github.com/spf13/viper from 1.10.0 to 1.18.2.

Release notes

Sourced from github.com/spf13/viper's releases.

v1.18.2

tl;dr Skip 1.18.0 and 1.18.1 and upgrade to this version instead.

This release fixes a regression that appears in rare circumstances when using Unmarshal or UnmarshalExact to decode values onto pointers with multiple indirection (eg. pointer to a pointer, etc). The change was introduced in 1.18.0 as a means to resolve a long-standing bug when decoding environment variables to structs.

The feature is now disabled by default and can be enabled using the viper_bind_struct build tag. It's also considered experimental at this point, so breaking changes may be introduced in the future.

What's Changed

Bug Fixes 🐛

Full Changelog: spf13/viper@v1.18.1...v1.18.2

v1.18.1

What's Changed

Bug Fixes 🐛

Full Changelog: spf13/viper@v1.18.0...v1.18.1

v1.18.0

Major changes

Highlighting some of the changes for better visibility.

Please share your feedback in the Discussion forum. Thanks! ❤️

AutomaticEnv works with Unmarshal

Previously, environment variables that weren't bound manually or had no defaults could not be mapped by Unmarshal. (The problem is explained in details in this issue: #761)

#1429 introduced a solution that solves that issue.

What's Changed

Enhancements 🚀

Bug Fixes 🐛

Dependency Updates ⬆️

... (truncated)

Commits
  • ab3a50c fix!: hide struct binding behind a feature flag
  • 9154b90 build(deps): bump actions/setup-go from 4.1.0 to 5.0.0
  • 08e4a00 build(deps): bump github/codeql-action from 2.22.8 to 2.22.9
  • fb6eb1e fix: merge missing struct keys inside UnmarshalExact
  • f5fcb4a chore: update crypt
  • f736363 fix isPathShadowedInFlatMap type cast bug (#1585)
  • 36a3868 Review changes
  • f0c4ccd fix: gocritic lint issues
  • 3a23b80 ci: enable test shuffle; fix tests
  • 73dfb94 feat: make Unmarshal work with AutomaticEnv
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.10.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.10.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 19, 2023
Copy link
Author

dependabot bot commented on behalf of github Dec 19, 2023

Dependabot tried to add @GarnettWang, @xiaozhouX and @osswangxining as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/kubeflow/arena/pulls/1018/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the kubeflow/arena repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Copy link

cr-gpt bot commented Dec 19, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign cheyang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce87d10) 16.97% compared to head (0d010e2) 16.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   16.97%   16.97%           
=======================================
  Files          28       28           
  Lines        1314     1314           
=======================================
  Hits          223      223           
  Misses       1086     1086           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Author

dependabot bot commented on behalf of github Jun 3, 2024

Superseded by #1092.

@dependabot dependabot bot closed this Jun 3, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/spf13/viper-1.18.2 branch June 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants