refac(math): refactor prime fields #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
TomTaehoonKim and
ashjeong
chokobole
force-pushed
the
refac/refactor-prime-fields
branch
8 times, most recently
from
ffc4a31
to
3e076c2
Compare
chokobole
force-pushed
the
refac/refactor-prime-fields
branch
from
3e076c2
to
8012561
Compare
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_config.h.tpl
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
refac/refactor-prime-fields
branch
from
8012561
to
3ca4413
Compare
ashjeong
reviewed
May 23, 2024
There was a problem hiding this comment.
Please change the following commits' titles/messages :
180b749
fix(math): instantiate XXXGpu with the same PrimeField class for sm…
c5d1e6f
refac(math): separate cpu.h.tpl into (small_)prime_field_cpu.h.tpl
a767713
build: enable avx512 extension when the flag is enabled
0188f04
perf(crypto): add round key to the first element only for the partial…
469be68
refac(math): separate config.h.tpl into (small_)prime_field_config.h… ….tpl...
Additionally, BigInt<N> value types have been changed to uint32_t for small prime fields
31e2b08
Please change “As the range has been extended,...” to “As the prime field scope has increased,…”
tachyon/math/finite_fields/generator/prime_field_generator/build_defs.bzl
Show resolved
Hide resolved
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_generator.cc
Show resolved
Hide resolved
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_generator.cc
Show resolved
Hide resolved
tachyon/math/finite_fields/goldilocks/goldilocks_prime_field_x86_special.h
Show resolved
Hide resolved
dongchangYoo
requested changes
May 24, 2024
…small prime fields
…ocks special version
chokobole
force-pushed
the
refac/refactor-prime-fields
branch
from
3ca4413
to
c089417
Compare
Insun35
reviewed
May 27, 2024
….h.tpl` Additionally, `BigInt<N>` value types have been changed to `uint32_t` for small prime fields.
Remove the use of `FromMontgomery()` and `ToMontgomery()` for passing values. These conversions were initially meaningful when supporting only EC-based prime fields. As the prime field scope has increased, this commit replaces these conversions with type casting instead.
chokobole
force-pushed
the
refac/refactor-prime-fields
branch
from
1703405
to
e7c9ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two key areas:
Initially, our prime fields were constructed based on EC-based prime fields, leading some interfaces (e.g., operator) to not be suitable for other types of prime fields. After internal discussion, we have decided on standardized interfaces for prime fields.