Fix the weird function signature of async callbacks #490
+13
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplodingCabbage
added a commit
that referenced
this pull request
Feb 15, 2024
ryota-ka
added a commit
to ryota-ka/DefinitelyTyped
that referenced
this pull request
Oct 1, 2024
…option, the diff result will now be passed as the first argument to the callback instead of the second kpdecker/jsdiff#490
ryota-ka
added a commit
to ryota-ka/DefinitelyTyped
that referenced
this pull request
Oct 8, 2024
…option, the diff result will now be passed as the first argument to the callback instead of the second kpdecker/jsdiff#490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
callbackoption had to be a function that takes the result as its second argument; the first argument, meanwhile, was never used. (Some tests name the parametererr; however, there is absolutely no circumstance in which an error, or anything besidesundefined, will be passed as the value of that argument.)This PR fixes this (utterly breaking backwards compat in the process) by making the result be passed as the value of the FIRST argument.
Resolves #462