Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version CLI showing 0.0.0 #2305

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

gaborbernat
Copy link
Collaborator

@gaborbernat gaborbernat commented Feb 6, 2025

Resolves #2304

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat changed the title fix ci fix: version CLI showing 0.0.0 Feb 6, 2025
@gaborbernat gaborbernat requested a review from koxudaxi February 6, 2025 17:02
Copy link
Owner

@koxudaxi koxudaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a private API, so there is no possibility that someone is using it as a module, but there is no problem to remove it.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #2305 will not alter performance

Comparing gaborbernat:fix-ci (3303613) with main (94c21e6)

Summary

✅ 31 untouched benchmarks

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (94c21e6) to head (3303613).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
- Coverage   99.93%   99.93%   -0.01%     
==========================================
  Files          38       37       -1     
  Lines        4317     4316       -1     
  Branches      720      720              
==========================================
- Hits         4314     4313       -1     
  Misses          1        1              
  Partials        2        2              
Flag Coverage Δ
unittests 99.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaborbernat gaborbernat merged commit 2eac729 into koxudaxi:main Feb 6, 2025
38 checks passed
@gaborbernat gaborbernat deleted the fix-ci branch February 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI Version Display Bug in 0.27.0
2 participants