Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom package install in CI is not working #2302

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

gaborbernat
Copy link
Collaborator

@gaborbernat gaborbernat commented Feb 4, 2025

Created tox environments for these custom variants so one can replicate it easily locally. You'll need to update the check list again as I do not have access to the settings of this repo.

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #2302 will not alter performance

Comparing gaborbernat:fix-ci (e94eefa) with main (0204b72)

Summary

✅ 31 untouched benchmarks

@gaborbernat
Copy link
Collaborator Author

Seems the CI is broken, but that's because we are operating correctly 😆

@gaborbernat gaborbernat marked this pull request as draft February 5, 2025 02:08
@gaborbernat gaborbernat force-pushed the fix-ci branch 6 times, most recently from d00bfd7 to f0e6316 Compare February 5, 2025 04:47
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the fix-ci branch 5 times, most recently from c4927dc to 241200e Compare February 5, 2025 04:55
@gaborbernat gaborbernat marked this pull request as ready for review February 5, 2025 04:56
@gaborbernat gaborbernat changed the title Fix custom package install in CI is overriden Fix custom package install in CI is not working Feb 5, 2025
@gaborbernat gaborbernat force-pushed the fix-ci branch 2 times, most recently from 014d6a3 to c0939f0 Compare February 5, 2025 04:58
@gaborbernat
Copy link
Collaborator Author

gaborbernat commented Feb 5, 2025

@koxudaxi ok this now should be working 👍 needed some change dirs (our own pyproject.toml polluting isort) and some more ignores for various new warnings popping up, but now is all good 👍

FYI: you can now do tox p to run all environments and test in parallel locally:

tox p
...
  fix: OK (1.92=setup[0.09]+cmd[1.83] seconds)
  3.13: OK (51.71=setup[0.08]+cmd[51.31,0.32] seconds)
  3.12: OK (47.84=setup[0.14]+cmd[47.04,0.66] seconds)
  3.11: OK (43.15=setup[0.17]+cmd[41.65,1.33] seconds)
  3.10: OK (50.02=setup[0.16]+cmd[49.36,0.50] seconds)
  3.9: OK (48.99=setup[0.16]+cmd[48.40,0.42] seconds)
  3.8: OK (53.24=setup[0.15]+cmd[52.84,0.25] seconds)
  readme: OK (0.77=setup[0.10]+cmd[0.67] seconds)
  coverage: OK (47.20=setup[0.05]+cmd[31.91,4.71,4.72,5.56,0.25] seconds)
  py3.12-black24: OK (46.69=setup[0.17]+cmd[45.82,0.70] seconds)
  py3.12-black23: OK (51.17=setup[0.15]+cmd[50.61,0.42] seconds)
  py3.12-black22: OK (58.27=setup[0.08]+cmd[57.91,0.28] seconds)
  py3.9-black19: OK (46.16=setup[0.09]+cmd[45.54,0.53] seconds)
  py3.8-pydantic18: OK (41.05=setup[0.17]+cmd[40.67,0.22] seconds)
  py3.8-isort4: OK (39.31=setup[0.16]+cmd[38.93,0.22] seconds)
  pkg_meta: OK (4.87=setup[0.10]+cmd[4.14,0.41,0.21] seconds)
  congratulations :) (133.29 seconds)

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (0204b72) to head (e94eefa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2302      +/-   ##
==========================================
+ Coverage   97.79%   99.93%   +2.13%     
==========================================
  Files          38       38              
  Lines        4317     4317              
  Branches      720      720              
==========================================
+ Hits         4222     4314      +92     
+ Misses         64        1      -63     
+ Partials       31        2      -29     
Flag Coverage Δ
unittests 99.93% <ø> (+2.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaborbernat gaborbernat force-pushed the fix-ci branch 2 times, most recently from abfcbb4 to 7aad16c Compare February 5, 2025 05:11
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Collaborator Author

@koxudaxi ping on this (you can also give me more rights to change repository config myself 😅).

@koxudaxi
Copy link
Owner

koxudaxi commented Feb 6, 2025

@gaborbernat
Sorry, I was in bed with a cold and fever. I'll take a look soon.

@koxudaxi koxudaxi merged commit dd32694 into koxudaxi:main Feb 6, 2025
38 checks passed
@gaborbernat
Copy link
Collaborator Author

No worries, will cut a release to see if it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants