-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom package install in CI is not working #2302
Conversation
CodSpeed Performance ReportMerging #2302 will not alter performanceComparing Summary
|
Seems the CI is broken, but that's because we are operating correctly 😆 |
d00bfd7
to
f0e6316
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
c4927dc
to
241200e
Compare
014d6a3
to
c0939f0
Compare
@koxudaxi ok this now should be working 👍 needed some change dirs (our own pyproject.toml polluting isort) and some more ignores for various new warnings popping up, but now is all good 👍 FYI: you can now do
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 97.79% 99.93% +2.13%
==========================================
Files 38 38
Lines 4317 4317
Branches 720 720
==========================================
+ Hits 4222 4314 +92
+ Misses 64 1 -63
+ Partials 31 2 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abfcbb4
to
7aad16c
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@koxudaxi ping on this (you can also give me more rights to change repository config myself 😅). |
@gaborbernat |
No worries, will cut a release to see if it works 👍 |
Created tox environments for these custom variants so one can replicate it easily locally. You'll need to update the check list again as I do not have access to the settings of this repo.