-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to use uv instead of poetry #2288
Conversation
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@koxudaxi any update on this? I have another bug I'd like to addrtess, and this is blocking me 😊 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 38 38
Lines 4307 4305 -2
Branches 994 838 -156
==========================================
- Hits 4307 4305 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2288 will improve performances by 11.57%Comparing 🎉 Hooray!
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
⚡ | test_main_jsonschema_collapsed_external_references |
80.9 ms | 72.5 ms | +11.57% |
⚡ | test_main_jsonschema_multiple_files |
82 ms | 74.4 ms | +10.24% |
⚡ | test_main_jsonschema_no_empty_collapsed_external_model |
51 ms | 46.2 ms | +10.44% |
Ah, I slighthly renamed the GitHub actions so shows more info in my browser without needing to click into it, which causes the missing checks. Should I restore the old naming or you OK updating the required checks? |
Thank you very much for creating PR!! |
Hmm, unsure why the coverage decreased, I haven't touched any of those files 🤔 |
Orthogonal to this change set, but given that |
Looking at https://app.codecov.io/gh/koxudaxi/datamodel-code-generator/pull/2288/indirect-changes#6e0ac031c1cc8fb390d8111b0e1d795b-L194, I apologize, but it's getting late here so I will check this again tomorrow. Regarding tox-uv, while it's welcome, I will also read the documentation tomorrow myself. |
Disclaimer I am the auther and maintainer of both |
The coverage was fixed after re-running only that specific task. |
Another orthogonal question, would you be open to switch to a |
This PR seems to have changed a lot of dependencies to be required that were optional before: prance = { version = ">=0.18.2", optional = true }
openapi-spec-validator = { version = ">=0.2.8,<0.7.0", optional = true }
PySnooper = { version = ">=0.4.1,<2.0.0", optional = true }
httpx = { version = "*", optional = true }
graphql-core = {version = "^3.2.3", optional = true} Is this intentional or an oversight? My Apologies, if this has been discussed before, but I could not find it. |
Not sure what optional dependency is for Poetry. Core Python doesn't have that concept only extras. How did poetry map these to standard dependencies? |
@gaborbernat, PTAL at Extras - poetry. My understanding reading that is, in poetry, you use it to specify version constraints for optional dependency, which later you are going to use in I think you could simply get rid of these dependencies from |
OK, I have released the fixed version |
Use hatchling instead of poetry for backend, uv otherwise.
Resolves #2220