Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http query parameters #1911

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

kevin-lithic
Copy link
Contributor

The goal of this is to be able to specify some set of query parameters that can be used on all calls when pulling schemas. This is particularly important because we want to be able to use GitHub to manage our schema versions and allow developers to generate their schemas from custom branches.

@kevin-lithic
Copy link
Contributor Author

@koxudaxi do I need to do something to get this to move thru the status checks?

Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #1911 will not alter performance

Comparing kevin-lithic:http-query-parameters (4f0643a) with main (c0d5c88)

Summary

✅ 29 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c0d5c88). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage        ?   98.89%           
=======================================
  Files           ?       37           
  Lines           ?     4171           
  Branches        ?      971           
=======================================
  Hits            ?     4125           
  Misses          ?       29           
  Partials        ?       17           
Flag Coverage Δ
unittests 98.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi merged commit 38fd1c6 into koxudaxi:main Apr 16, 2024
92 checks passed
simontaurus added a commit to OO-LD/playground-python-yaml that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants