Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rootmodel template with reuse-model #1902

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

atti92
Copy link
Contributor

@atti92 atti92 commented Apr 5, 2024

We get an error on the black formatter when using --reuse-model, because it tries to save inherited RootModels with an empty []

class Limits(Requests[])):
    pass

The change removes the empty brackets []

Copy link

codspeed-hq bot commented Apr 7, 2024

CodSpeed Performance Report

Merging #1902 will not alter performance

Comparing atti92:atti92-patch-1 (eb833ab) with main (04f8e77)

Summary

✅ 29 untouched benchmarks

@atti92
Copy link
Contributor Author

atti92 commented Apr 8, 2024

@koxudaxi PR failed with codecov upload:

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255```

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f8c4506). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1902   +/-   ##
=======================================
  Coverage        ?   98.89%           
=======================================
  Files           ?       37           
  Lines           ?     4171           
  Branches        ?      971           
=======================================
  Hits            ?     4125           
  Misses          ?       29           
  Partials        ?       17           
Flag Coverage Δ
unittests 98.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi merged commit a3371cb into koxudaxi:main Apr 16, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants