[Fix rubocop#12769] Fix a false positive for Lint/RedundantWithIndex

Fixes rubocop#12769. This PR fixes a false positive for `Lint/RedundantWithIndex` when calling `with_index` with receiver and a block.
koic · Mar 13, 2024 · e7d4e31 · e7d4e31
1 parent afddf65
commit e7d4e31
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/changelog/fix_a_false_positive_for_lint_redundant_with_index.md b/changelog/fix_a_false_positive_for_lint_redundant_with_index.md
@@ -0,0 +1 @@
+* [#12769](https://github.com/rubocop/rubocop/issues/12769): Fix a false positive for `Lint/RedundantWithIndex` when calling `with_index` with receiver and a block. ([@koic][])
diff --git a/lib/rubocop/cop/lint/redundant_with_index.rb b/lib/rubocop/cop/lint/redundant_with_index.rb
@@ -33,8 +33,10 @@ class RedundantWithIndex < Base
         MSG_EACH_WITH_INDEX = 'Use `each` instead of `each_with_index`.'
         MSG_WITH_INDEX = 'Remove redundant `with_index`.'
 
+        # rubocop:disable Metrics/AbcSize
         def on_block(node)
           return unless node.receiver
+          return if node.method?(:with_index) && !node.receiver.receiver
           return unless (send = redundant_with_index?(node))
 
           range = with_index_range(send)
@@ -48,6 +50,7 @@ def on_block(node)
             end
           end
         end
+        # rubocop:enable Metrics/AbcSize
 
         alias on_numblock on_block
 

diff --git a/spec/rubocop/cop/lint/redundant_with_index_spec.rb b/spec/rubocop/cop/lint/redundant_with_index_spec.rb
@@ -101,6 +101,10 @@
       expect_no_offenses('ary.each_with_index { _1; _2 }')
     end
 
+    it 'accepts with_index with receiver and a block' do
+      expect_no_offenses('ary.with_index { |v| v }')
+    end
+
     it 'accepts with_index without receiver with a block' do
       expect_no_offenses('with_index { |v| v }')
     end