[Fix rubocop#12154] Fix incorrect diagnosticProvider value of LSP

Fixes rubocop#12154. This PR fixes incorrect `diagnosticProvider` value of LSP. `diagnosticProvider` cannot accept true as below. This PR replaces the originally acceptable value. ```typescript /** * The server has support for pull model diagnostics. * * @SInCE 3.17.0 */ diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions; ``` https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize
koic · Aug 27, 2023 · 2df1fd8 · 2df1fd8
1 parent 4f46bc4
commit 2df1fd8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/changelog/fix_incorrect_diagnostic_provider_value_of_lsp.md b/changelog/fix_incorrect_diagnostic_provider_value_of_lsp.md
@@ -0,0 +1 @@
+* [#12154](https://github.com/rubocop/rubocop/issues/12154): Fix incorrect `diagnosticProvider` value of LSP. ([@koic][])
diff --git a/lib/rubocop/lsp/routes.rb b/lib/rubocop/lsp/routes.rb
@@ -45,7 +45,10 @@ def for(name)
           result: LanguageServer::Protocol::Interface::InitializeResult.new(
             capabilities: LanguageServer::Protocol::Interface::ServerCapabilities.new(
               document_formatting_provider: true,
-              diagnostic_provider: true,
+              diagnostic_provider: LanguageServer::Protocol::Interface::DiagnosticOptions.new(
+                inter_file_dependencies: false,
+                workspace_diagnostics: false
+              ),
               text_document_sync: LanguageServer::Protocol::Interface::TextDocumentSyncOptions.new(
                 change: LanguageServer::Protocol::Constant::TextDocumentSyncKind::FULL,
                 open_close: true

diff --git a/spec/rubocop/lsp/server_spec.rb b/spec/rubocop/lsp/server_spec.rb
@@ -38,7 +38,7 @@
           capabilities: {
             textDocumentSync: { openClose: true, change: 1 },
             documentFormattingProvider: true,
-            diagnosticProvider: true
+            diagnosticProvider: { interFileDependencies: false, workspaceDiagnostics: false }
           }
         }
       )