(tmp) github actions testing #4354
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves this warning… ``` [DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API (Use `node --trace-deprecation ...` to show where the warning was created) ``` …by swapping out module.issuer for moduleGraph.getIssuer(module). PR on upstream: - grassator/webpack-extract-translation-keys#23
- Key on runner.os, package-lock.json, and package patches if any - Run postinstall copy-fonts separately if using cached node_modules
- Relabel names - See if this uses the cache
p2edwards
changed the title
|
p2edwards
force-pushed
the
tmp-github-actions-tests
branch
3 times, most recently
from
6a6b5f6
to
122b1fc
Compare
p2edwards
force-pushed
the
tmp-github-actions-tests
branch
2 times, most recently
from
bd12893
to
122b1fc
Compare
"Before I forget", let's include node version in the cache key. The contents of node_modules after `npm install` may differ if the Node version (or npm) changes. So to prevent cache misuse, this version string should be included in the cache key somewhere. We don't quite need this yet, since we only recently started caching node_modules, and all CI tests are still on the same version (v16.15.0, with stock npm 8.5.5). It's just that we'll want this in place before someone starts experimenting with moving past 16.15.0, because the cache is reused across different branches.
noliveleger
force-pushed
the
beta
branch
2 times, most recently
from
d0b0d13
to
fd5246d
Compare
|
research log
|
2 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a multipurpose draft/temp PR for testing changes for github-actions.
The main purpose is to iterate on issues like #4337, without cluttering other branches or PR's with lots of small commits that are mainly just for triggering slightly different test runs. Any results found here will probably be ported into other PRs rather than merging this one.