Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: fail with 404 instead of gzip error when url was wrong #879

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Nov 3, 2022

       -S, --show-error
              When used with -s, --silent, it makes curl show an error message if it fails.
       -f, --fail
              (HTTP) Fail silently (no output at all) on server errors. This is mostly done to enable scripts etc to better deal with failed attempts. In
              normal cases when an HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and
              more). This flag will prevent curl from outputting that and return error 22.

@google-cla
Copy link

google-cla bot commented Nov 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imjasonh
Copy link
Member

imjasonh commented Nov 3, 2022

Thanks for this! I should also update https://github.com/imjasonh/setup-ko/blob/main/action.yml#L41 accordingly.

@grosser
Copy link
Contributor Author

grosser commented Nov 3, 2022

merge ?

@imjasonh imjasonh merged commit da6b9c1 into ko-build:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants