Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix GH Pages publishing #843

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Conversation

imjasonh
Copy link
Member

This uses a GH Actions workflow to publish: https://github.com/marketplace/actions/deploy-mkdocs

It sets CUSTOM_DOMAIN: ko.build so there's a CNAME file at the root of the gh-pages branch, which is needed to serve requests from the custom domain.

This also fixes the edit URL to edit the main branch instead of the (default, 404) master branch.

jonjohnsonjr
jonjohnsonjr previously approved these changes Oct 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #843 (a3a0789) into main (4f6bd9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   51.16%   51.16%           
=======================================
  Files          44       44           
  Lines        3385     3385           
=======================================
  Hits         1732     1732           
  Misses       1426     1426           
  Partials      227      227           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit c518e5d into ko-build:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants