Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and test using 1.18 and 1.19 (drop 1.17) #812

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Sep 6, 2022

k8s apimachinery now seems to require 1.18: #804

Since 1.19 came out last month, 1.17 is no longer officially supported.

This PR also removes the Go 1.18 compat e2e test, which should also let us remove some pre-1.18 compat code in a future PR. edit: just went ahead and removed the pre-1.18 code.

@codecov-commenter
Copy link

Codecov Report

Merging #812 (01d4be8) into main (3f0b618) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   51.40%   51.37%   -0.03%     
==========================================
  Files          44       44              
  Lines        3354     3354              
==========================================
- Hits         1724     1723       -1     
  Misses       1408     1408              
- Partials      222      223       +1     
Impacted Files Coverage Δ
pkg/commands/version.go 47.36% <0.00%> (-5.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit 9a1eae8 into ko-build:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants