Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test if channel implementation exposes OIDC audience #7381

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add e2e test if channel implementation exposes OIDC audience #7381

merged 2 commits into from
Nov 10, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Oct 19, 2023

Proposed Changes

  • 馃巵 Add e2e test to check if channel implementation exposes OIDC audience in status (392b535)
  • 馃Ч Make some OIDC conformance tests private as they are wrapped in a feature set (e3cdd65)

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2023
@creydr
Copy link
Member Author

creydr commented Oct 19, 2023

/cc @pierDipi
Follow up on #7336 (comment) the InMemoryChannel for example is currently on of the candidates, which only supports OIDC partially (currently only exposure of Audience, but misses token validation)

@knative-prow knative-prow bot requested a review from pierDipi October 19, 2023 10:22
@creydr
Copy link
Member Author

creydr commented Oct 19, 2023

/retest

@creydr
Copy link
Member Author

creydr commented Oct 19, 2023

/assign @pierDipi

@creydr
Copy link
Member Author

creydr commented Oct 23, 2023

@pierDipi can you check on this?

@creydr
Copy link
Member Author

creydr commented Oct 23, 2023

/hold
for after the release cut

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@creydr
Copy link
Member Author

creydr commented Oct 26, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@creydr
Copy link
Member Author

creydr commented Nov 8, 2023

@pierDipi can you check on this?

@creydr
Copy link
Member Author

creydr commented Nov 9, 2023

/retest

@creydr
Copy link
Member Author

creydr commented Nov 10, 2023

/retest
/assign @Cali0707 @Leo6Leo

matzew
matzew approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9431ce9 into knative:main Nov 10, 2023
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

@pierDipi pierDipi

@Leo6Leo Leo6Leo

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@creydr @matzew @pierDipi @Leo6Leo @Cali0707