Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply EIP-5656, MCOPY #1980

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Apply EIP-5656, MCOPY #1980

merged 6 commits into from
Oct 4, 2023

Conversation

sjnam
Copy link
Contributor

@sjnam sjnam commented Sep 26, 2023 •
edited

Proposed changes

This PR applies EIP-5656, mcopy instruction

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@sjnam sjnam self-assigned this Sep 26, 2023
@hyunsooda
Copy link
Contributor

Could you please update the function NewEVMInterpreter() as well?

ian0371
ian0371 reviewed Sep 27, 2023
View reviewed changes
blockchain/vm/opcodes.go Outdated Show resolved Hide resolved
@sjnam @hyeonLewis
Update blockchain/vm/instructions_test.go
3c512e0 
Co-authored-by: Lewis <lewis.kim@klaytn.foundation>
blukat29
blukat29 previously approved these changes Oct 4, 2023
View reviewed changes
@sjnam sjnam merged commit cd09595 into klaytn:dev Oct 4, 2023
11 checks passed
@sjnam sjnam deleted the eip-5656-mcopy branch October 4, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@blukat29 blukat29 blukat29 left review comments

Assignees

@sjnam sjnam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sjnam @hyunsooda @blukat29 @ian0371 @yoomee1313 @hyeonLewis