zstd: Tweak noasm FSE decoder #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results below. On a different machine, I saw somewhat bigger
speedups when benchmarking a version that has the noasm version of FSE,
but asm seqdec. The paper-100k benchmarks have some extreme variance in
the first 12 runs, so I did 12 more to get a more reliable average. The
apparent regression on that benchmark may be a fluke.
The asm FSE decoder still wins.
goos: linux
goarch: amd64
pkg: github.com/klauspost/compress/zstd
cpu: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
│ old │ new │
│ B/s │ B/s vs base │
Decoder_DecoderSmall/kppkn.gtb.zst/buffered-8 252.3Mi ± 0% 251.9Mi ± 0% -0.12% (p=0.027 n=12)
Decoder_DecoderSmall/kppkn.gtb.zst/unbuffered-8 300.2Mi ± 1% 299.5Mi ± 1% ~ (p=0.977 n=12)
Decoder_DecoderSmall/geo.protodata.zst/buffered-8 702.1Mi ± 0% 701.4Mi ± 0% ~ (p=0.551 n=12)
Decoder_DecoderSmall/geo.protodata.zst/unbuffered-8 703.1Mi ± 1% 695.9Mi ± 1% ~ (p=0.178 n=12)
Decoder_DecoderSmall/plrabn12.txt.zst/buffered-8 200.3Mi ± 0% 200.2Mi ± 0% ~ (p=0.417 n=12)
Decoder_DecoderSmall/plrabn12.txt.zst/unbuffered-8 294.3Mi ± 2% 294.2Mi ± 2% ~ (p=0.755 n=12)
Decoder_DecoderSmall/lcet10.txt.zst/buffered-8 237.7Mi ± 0% 237.7Mi ± 0% ~ (p=0.561 n=12)
Decoder_DecoderSmall/lcet10.txt.zst/unbuffered-8 315.7Mi ± 1% 313.0Mi ± 2% ~ (p=0.713 n=12)
Decoder_DecoderSmall/asyoulik.txt.zst/buffered-8 205.7Mi ± 3% 212.8Mi ± 0% +3.43% (p=0.002 n=12)
Decoder_DecoderSmall/asyoulik.txt.zst/unbuffered-8 267.1Mi ± 2% 273.4Mi ± 4% ~ (p=0.078 n=12)
Decoder_DecoderSmall/alice29.txt.zst/buffered-8 194.8Mi ± 0% 194.8Mi ± 0% ~ (p=0.876 n=12)
Decoder_DecoderSmall/alice29.txt.zst/unbuffered-8 219.8Mi ± 2% 221.5Mi ± 1% ~ (p=0.410 n=12)
Decoder_DecoderSmall/html_x_4.zst/buffered-8 1.512Gi ± 1% 1.550Gi ± 0% +2.49% (p=0.000 n=12)
Decoder_DecoderSmall/html_x_4.zst/unbuffered-8 1.149Gi ± 2% 1.196Gi ± 2% +4.09% (p=0.000 n=12)
Decoder_DecoderSmall/paper-100k.pdf.zst/buffered-8 2.504Gi ± 1% 2.513Gi ± 0% ~ (p=0.136 n=24)
Decoder_DecoderSmall/paper-100k.pdf.zst/unbuffered-8 1.041Gi ± 3% 1.023Gi ± 0% -1.72% (p=0.002 n=24)
Decoder_DecoderSmall/fireworks.jpeg.zst/buffered-8 6.315Gi ± 0% 6.349Gi ± 0% +0.53% (p=0.000 n=12)
Decoder_DecoderSmall/fireworks.jpeg.zst/unbuffered-8 3.178Gi ± 3% 3.234Gi ± 2% ~ (p=0.713 n=12)
Decoder_DecoderSmall/urls.10K.zst/buffered-8 350.9Mi ± 0% 351.0Mi ± 0% ~ (p=1.000 n=12)
Decoder_DecoderSmall/urls.10K.zst/unbuffered-8 525.8Mi ± 1% 524.9Mi ± 3% ~ (p=0.671 n=12)
Decoder_DecoderSmall/html.zst/buffered-8 562.0Mi ± 0% 561.2Mi ± 0% ~ (p=0.054 n=12)
Decoder_DecoderSmall/html.zst/unbuffered-8 537.4Mi ± 2% 543.5Mi ± 2% ~ (p=0.178 n=12)
Decoder_DecoderSmall/comp-data.bin.zst/buffered-8 283.4Mi ± 0% 283.8Mi ± 0% ~ (p=0.164 n=12)
Decoder_DecoderSmall/comp-data.bin.zst/unbuffered-8 118.0Mi ± 1% 120.3Mi ± 3% ~ (p=0.128 n=12)
geomean 505.1Mi 508.1Mi +0.60%
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jan 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.4` -> `v1.17.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
kodiakhq bot
pushed a commit
to cloudquery/filetypes
that referenced
this pull request
Feb 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.4` -> `v1.17.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot
pushed a commit
to cloudquery/codegen
that referenced
this pull request
Feb 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.4` -> `v1.17.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Feb 1, 2024
) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.4` -> `v1.17.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot
pushed a commit
to cloudquery/plugin-pb-go
that referenced
this pull request
Feb 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.4` -> `v1.17.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 5, 2024
…0855) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.4` -> `v1.17.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@​greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@​Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@​egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@​diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@​klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@​pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@​pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@​Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
](https://renovatebot.com){kind=link}
…en-telemetry#30855) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.4` -> `v1.17.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.5`](https://togithub.com/klauspost/compress/releases/tag/v1.17.5) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.4...v1.17.5) #### What's Changed - flate: Fix reset with dictionary on custom window encodes by [@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#912 - zstd: Limit better/best default window to 8MB by [@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#913 - zstd: Shorter and faster asm for decSymbol.newState by [@&open-telemetry#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#896 - zstd: Add Frame header encoding and stripping by [@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#908 - zstd: Tweak noasm FSE decoder by [@&open-telemetry#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#910 - s2: Fix callbacks for skippable blocks and disallow 0xfe (Padding) for custom use by [@&open-telemetry#8203;Jille](https://togithub.com/Jille) in [klauspost/compress#916 - s2: Fix incorrect length encoded by writer.AddSkippableBlock by [@&open-telemetry#8203;Jille](https://togithub.com/Jille) in [klauspost/compress#917 - s2: Fix up AddSkippableBlock more by [@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#919 - s2: Document and test how to peek the stream for skippable blocks by [@&open-telemetry#8203;Jille](https://togithub.com/Jille) in [klauspost/compress#918 - internal/race,s2: add some race instrumentation by [@&open-telemetry#8203;egonelbre](https://togithub.com/egonelbre) in [klauspost/compress#903 - build(deps): bump the github-actions group with 4 updates by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [klauspost/compress#900 - CI: Hash pin sensitive actions and configure Dependabot to automatically update them by [@&open-telemetry#8203;diogoteles08](https://togithub.com/diogoteles08) in [klauspost/compress#899 - Update generator and executable go.mod by [@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#904 - Update README.md by [@&open-telemetry#8203;pelenium](https://togithub.com/pelenium) in [klauspost/compress#905 - build(deps): bump the github-actions group with 1 update by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [klauspost/compress#906 #### New Contributors - [@&open-telemetry#8203;pelenium](https://togithub.com/pelenium) made their first contribution in [klauspost/compress#905 - [@&open-telemetry#8203;Jille](https://togithub.com/Jille) made their first contribution in [klauspost/compress#916 **Full Changelog**: klauspost/compress@v1.17.4...v1.17.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results below. On a different machine, I saw somewhat bigger speedups when benchmarking a version that has the noasm version of FSE, but asm seqdec. The paper-100k benchmarks have some extreme variance in the first 12 runs, so I did 12 more to get a more reliable average. The apparent regression on that benchmark may be a fluke.
The asm FSE decoder still wins.