Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzhttp: Fix missing content type on Close #883

Merged
merged 1 commit into from Nov 10, 2023

Conversation

klauspost
Copy link
Owner

If compression had not yet been triggered in Write, be sure to detect content type on Close.

Fixes #882

If compression had not yet been triggered in Write, be sure to detect content type on Close.

Fixes #882
@klauspost klauspost changed the title Fix missing content type on Close gzhttp: Fix missing content type on Close Nov 10, 2023
@klauspost klauspost merged commit 80ba129 into master Nov 10, 2023
18 checks passed
@klauspost klauspost deleted the gzhttp-detect-content-type branch November 10, 2023 10:59
codeboten pushed a commit to open-telemetry/opentelemetry-collector that referenced this pull request Nov 21, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/klauspost/compress](https://togithub.com/klauspost/compress)
| require | patch | `v1.17.2` -> `v1.17.3` |

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare
Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

- fse: Fix max header size by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#881
- zstd: Improve better/best compression by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#877
- gzhttp: Fix missing content type on Close by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#883

**Full Changelog**:
klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 23, 2023
…9466)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/klauspost/compress](https://togithub.com/klauspost/compress)
| require | patch | `v1.17.2` -> `v1.17.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare
Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

- fse: Fix max header size by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#881
- zstd: Improve better/best compression by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#877
- gzhttp: Fix missing content type on Close by
[@&#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#883

**Full Changelog**:
klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…en-telemetry#29466)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/klauspost/compress](https://togithub.com/klauspost/compress)
| require | patch | `v1.17.2` -> `v1.17.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare
Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

- fse: Fix max header size by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#881
- zstd: Improve better/best compression by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#877
- gzhttp: Fix missing content type on Close by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#883

**Full Changelog**:
klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
kodiakhq bot pushed a commit to cloudquery/filetypes that referenced this pull request Dec 1, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.2` -> `v1.17.3` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

### [`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

-   fse: Fix max header size by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#881
-   zstd: Improve better/best compression by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#877
-   gzhttp: Fix missing content type on Close by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#883

**Full Changelog**: klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
pantuza pushed a commit to pantuza/opentelemetry-collector that referenced this pull request Dec 8, 2023
…y#8968)

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/klauspost/compress](https://togithub.com/klauspost/compress)
| require | patch | `v1.17.2` -> `v1.17.3` |

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare
Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

- fse: Fix max header size by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#881
- zstd: Improve better/best compression by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#877
- gzhttp: Fix missing content type on Close by
[@&open-telemetry#8203;klauspost](https://togithub.com/klauspost) in
[klauspost/compress#883

**Full Changelog**:
klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
kodiakhq bot pushed a commit to cloudquery/codegen that referenced this pull request Jan 1, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.2` -> `v1.17.4` |

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

### [`v1.17.4`](https://togithub.com/klauspost/compress/releases/tag/v1.17.4)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.3...v1.17.4)

#### What's Changed

-   huff0: Speed up symbol counting by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#887
-   huff0: Remove byteReader by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#886
-   gzhttp: Allow overriding decompression on transport by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#892
-   gzhttp: Clamp compression level by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#890
-   gzip: Error out if reserved bits are set by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#891

#### New Contributors

-   [@&#8203;teikjun](https://togithub.com/teikjun) made their first contribution in [klauspost/compress#889

**Full Changelog**: klauspost/compress@v1.17.3...v1.17.4

### [`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

-   fse: Fix max header size by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#881
-   zstd: Improve better/best compression by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#877
-   gzhttp: Fix missing content type on Close by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#883

**Full Changelog**: klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot pushed a commit to cloudquery/plugin-pb-go that referenced this pull request Jan 1, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.2` -> `v1.17.4` |

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

### [`v1.17.4`](https://togithub.com/klauspost/compress/releases/tag/v1.17.4)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.3...v1.17.4)

#### What's Changed

-   huff0: Speed up symbol counting by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#887
-   huff0: Remove byteReader by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#886
-   gzhttp: Allow overriding decompression on transport by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#892
-   gzhttp: Clamp compression level by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#890
-   gzip: Error out if reserved bits are set by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#891

#### New Contributors

-   [@&#8203;teikjun](https://togithub.com/teikjun) made their first contribution in [klauspost/compress#889

**Full Changelog**: klauspost/compress@v1.17.3...v1.17.4

### [`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

-   fse: Fix max header size by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#881
-   zstd: Improve better/best compression by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#877
-   gzhttp: Fix missing content type on Close by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#883

**Full Changelog**: klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Jan 1, 2024
)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | indirect | patch | `v1.17.2` -> `v1.17.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

### [`v1.17.4`](https://togithub.com/klauspost/compress/releases/tag/v1.17.4)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.3...v1.17.4)

##### What's Changed

-   huff0: Speed up symbol counting by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#887
-   huff0: Remove byteReader by [@&#8203;greatroar](https://togithub.com/greatroar) in [klauspost/compress#886
-   gzhttp: Allow overriding decompression on transport by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#892
-   gzhttp: Clamp compression level by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#890
-   gzip: Error out if reserved bits are set by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#891

##### New Contributors

-   [@&#8203;teikjun](https://togithub.com/teikjun) made their first contribution in [klauspost/compress#889

**Full Changelog**: klauspost/compress@v1.17.3...v1.17.4

### [`v1.17.3`](https://togithub.com/klauspost/compress/releases/tag/v1.17.3)

[Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.2...v1.17.3)

#### What's Changed

-   fse: Fix max header size by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#881
-   zstd: Improve better/best compression by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#877
-   gzhttp: Fix missing content type on Close by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/compress#883

**Full Changelog**: klauspost/compress@v1.17.2...v1.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content type is not set when HTB is used with a small buffer
1 participant