Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rstest test framework #399

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

ftupas
Copy link
Contributor

@ftupas ftupas commented Aug 8, 2023

Time spent on this PR: 1

Resolves: #393

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Use rstest as test framework to add fixtures and parameterization of tests

Does this introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 86.95% and project coverage change: +61.10% 🎉

Comparison is base (71506a8) 23.17% compared to head (12d50e5) 84.27%.
Report is 143 commits behind head on main.

❗ Current head 12d50e5 differs from pull request most recent head 8960cc4. Consider uploading reports for the commit 8960cc4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #399       +/-   ##
===========================================
+ Coverage   23.17%   84.27%   +61.10%     
===========================================
  Files           9       38       +29     
  Lines        1247     3276     +2029     
===========================================
+ Hits          289     2761     +2472     
+ Misses        958      515      -443     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.57% <ø> (ø)
crates/core/src/test_utils/deploy_helpers.rs 97.43% <ø> (ø)
crates/core/src/test_utils/fixtures.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/web3_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/config.rs 100.00% <ø> (ø)
crates/eth-rpc/src/lib.rs 93.33% <ø> (ø)
... and 28 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/core/tests/client.rs Outdated Show resolved Hide resolved
crates/core/tests/fixtures.rs Outdated Show resolved Hide resolved
crates/core/tests/fixtures.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, it's nice to remove more and more boilerplate code!

crates/core/tests/fixtures.rs Outdated Show resolved Hide resolved
crates/core/tests/fixtures.rs Outdated Show resolved Hide resolved
crates/core/tests/client.rs Show resolved Hide resolved
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ftupas ftupas added this pull request to the merge queue Aug 10, 2023
Merged via the queue into kkrt-labs:main with commit 9696424 Aug 10, 2023
6 checks passed
@ftupas ftupas deleted the feat/add-rstest-fixture branch August 10, 2023 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a fixture framework
2 participants