Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footnote attributes that mirror cmark-gfm #273

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

digitalmoksha
Copy link
Collaborator

This aligns the footnote output with cmark-gfm. Relates to #259

@kivikakk
Copy link
Owner

kivikakk commented Jan 25, 2023

Hi @digitalmoksha — thanks so much for this, this is great.

The spec builds are failing, but that's only because the extensions.txt spec in our vendored cmark-gfm doesn't match the new output. I tried pulling in the current upstream for that part of the file, and it also doesn't quite work due to some remaining differences in footnote ID generation (and a parsing issue with footnotes like Hello[^"><script>alert(1)</script>], which are apparently supported!).

That's fine with me — I'll address it in a follow-up PR. This here is great.

@digitalmoksha
Copy link
Collaborator Author

Thanks @kivikakk for getting this over the line 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants