Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: final tweaks to messenger #86

Merged
merged 7 commits into from Oct 9, 2023
Merged

Conversation

gk-kindred
Copy link
Collaborator

  • Some refactors and renames
  • Change how whitelist of actions are fed to the messenger service
  • Move messenger suffix related get_mut and get_meta to the core suffix.
  • Handle how actions failed to process will be marked in the suffix

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (f97e6f5) 57.09% compared to head (c4d5e63) 57.10%.

❗ Current head c4d5e63 differs from pull request most recent head fe0dbbf. Consider uploading reports for the commit fe0dbbf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   57.09%   57.10%   +0.01%     
==========================================
  Files         114      115       +1     
  Lines        5589     5670      +81     
==========================================
+ Hits         3191     3238      +47     
- Misses       2398     2432      +34     
Files Coverage Δ
packages/talos_cohort_replicator/src/core.rs 9.52% <ø> (ø)
...ages/talos_messenger_actions/src/kafka/producer.rs 0.00% <ø> (ø)
packages/talos_messenger_core/src/tests/utils.rs 96.77% <100.00%> (+0.72%) ⬆️
packages/talos_rdkafka_utils/src/kafka_config.rs 87.50% <100.00%> (ø)
packages/talos_suffix/src/core.rs 100.00% <ø> (ø)
packages/talos_suffix/src/suffix.rs 90.83% <ø> (ø)
...certifier/src/services/message_receiver_service.rs 66.66% <0.00%> (ø)
...ier/src/services/tests/message_receiver_service.rs 74.69% <0.00%> (ø)
...ges/talos_certifier_adapters/src/kafka/consumer.rs 0.00% <0.00%> (ø)
packages/talos_messenger_core/src/core.rs 0.00% <0.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -2,12 +2,41 @@ use ahash::HashMap;
use serde::{Deserialize, Serialize}; // 1.0.130
use serde_json::{self};

fn default_text_plain_encoding() -> String {
"text/plain".to_string()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons why did you methods instead of constants?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually didn't like this approach as well, but serde supports assigning custom default values only via functions or methods.

You can refer to this long running issue which was opened in 2016, and still active discussions on it.

I looked at some suggestions, and thought maybe it's an overkill for now, and just kept it simple with the function

@gk-kindred gk-kindred merged commit 86e1454 into master Oct 9, 2023
2 checks passed
@gk-kindred gk-kindred deleted the feature/messenger-todo-items-1 branch October 9, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants