forked from Kotlin/kotlinx.coroutines
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Properly round
Duration
instances to milliseconds
Prior to this commit Durations used in for delays or timeouts lost their nanosecond granularity when being converted to a millisecond Long value. This effectively meant that delays could resume prior to when they were scheduled to do so. This commit solves this by rounding a Duration with nanosecond components up to the next largest millisecond. Closes Kotlin#3920
- Loading branch information
1 parent
ed0cf7a
commit de265b0
Showing
2 changed files
with
55 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
kotlinx-coroutines-core/common/test/DurationToMillisTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2016-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
package kotlinx.coroutines | ||
|
||
import kotlin.test.* | ||
import kotlin.time.Duration.Companion.milliseconds | ||
import kotlin.time.Duration.Companion.nanoseconds | ||
import kotlin.time.Duration.Companion.seconds | ||
|
||
class DurationToMillisTest { | ||
|
||
@Test fun negative_duration_coerced_to_zero_millis() = assertEquals( | ||
expected = 0L, | ||
actual = (-1).seconds.toDelayMillis(), | ||
) | ||
|
||
@Test fun zero_duration_coerced_to_zero_millis() = assertEquals( | ||
expected = 0L, | ||
actual = 0.seconds.toDelayMillis(), | ||
) | ||
|
||
@Test fun one_nanosecond_coerced_to_one_millisecond() = assertEquals( | ||
expected = 1L, | ||
actual = 1.nanoseconds.toDelayMillis(), | ||
) | ||
|
||
@Test fun one_second_coerced_to_1000_milliseconds() = assertEquals( | ||
expected = 1_000L, | ||
actual = 1.seconds.toDelayMillis(), | ||
) | ||
|
||
@Test fun mixed_component_duration_rounded_up_to_next_millisecond() = assertEquals( | ||
expected = 999L, | ||
actual = (998.milliseconds + 75909.nanoseconds).toDelayMillis(), | ||
) | ||
|
||
@Test fun one_extra_nanosecond_rounded_up_to_next_millisecond() = assertEquals( | ||
expected = 999L, | ||
actual = (998.milliseconds + 1.nanoseconds).toDelayMillis(), | ||
) | ||
} |