Bugfix/normalization invert #17501
Merged
Bugfix/normalization invert #17501
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
google-ml-butler
bot
added
the
keras-team-review-pending
qlzh727
requested changes
Jan 30, 2023
See https://github.com/keras-team/keras/actions/runs/4044365513/jobs/6958299676 |
|
The format is still broken. Please use the format script in the repo https://github.com/keras-team/keras/blob/master/shell/format.sh |
|
FYI: I first tried running this script on the full repository. The Then the So I ended up running black on just the files I modified, which is what is committed now. Not sure how you want modified where, if this is still not what you want, can you apply these changes yourself? Thanks :) . |
qlzh727
approved these changes
Feb 1, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
rchao
removed
the
keras-team-review-pending
qlzh727
requested changes
Feb 2, 2023
See https://source.cloud.google.com/results/invocations/c5bfb743-1844-4093-8802-30cf7171cb07/log for more details. |
google-ml-butler
bot
removed
the
ready to pull
|
Sorry, I was confused on how to set A small note: is there a way for me to see the output of the CI/CD before you validate every step? :) I think not seeing the CI/CD output before you allow it to run is making it harder for me to catch this kind of stupid mistakes that the CI/CD would have reported to me at once otherwise :) . (I suppose CI/CD does not run automatically when I push so that you cannot get ddos:ed or something like this?) |
|
Any update on this? It is a quite 'impactful' bug (as models using inverse normalisation layer get destroyed with a save and load cycle as of today), would be great to push :) . |
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
Imported from GitHub PR #17501 Fix bug #17486 , by: - making sure the ```invert``` attribute is tracked when saving / loading - adding extra test for this case. Notes: - I am not too familiar with the keras tests setup, so the test I added may need editing - there are several tests around my new additional test, it is possible that one may want to add extra "invert" tests corresponding to each of these. Copybara import of the project: -- f5452d5 by JRT <jean.rblt@gmail.com>: Add invert attribute to get_config for Normalization -- a2cf8c9 by JRT <jean.rblt@gmail.com>: Add test for invert normalization load -- 04e4017 by JRT <jean.rblt@gmail.com>: Fix formatting -- b1660f0 by JRT <jean.rblt@gmail.com>: Run black to format -- ba1207c by JRT <jean.rblt@gmail.com>: Fix setting invert property Merging this change closes #17501 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17501 from jerabaul29:bugfix/normalization_invert ba1207c PiperOrigin-RevId: 509576868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug keras-team/tf-keras#281 , by:
invertattribute is tracked when saving / loadingNotes: