oci: Add a domainname field #5108
Closed
+613
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@utam0k Thank you! |
ManaSugi
reviewed
Sep 5, 2022
| @@ -47,6 +47,8 @@ pub struct Spec { | |||
| pub root: Option<Root>, | |||
| #[serde(default, skip_serializing_if = "String::is_empty")] | |||
| pub hostname: String, | |||
| #[serde(default, skip_serializing_if = "String::is_empty")] | |||
| pub domainname: String, | |||
There was a problem hiding this comment.
Could you add the domainname to the following files as well?
https://github.com/kata-containers/kata-containers/blob/main/src/libs/protocols/src/trans.rs
https://github.com/kata-containers/kata-containers/blob/main/src/libs/protocols/protos/oci.proto
Then, please run the https://github.com/kata-containers/kata-containers/blob/main/src/libs/protocols/hack/update-generated-proto.sh to update runtime/virtcontainers/pkg/agent/protocols/grpc/oci.pb.go
opencontainers/runtime-spec#1156 Signed-off-by: utam0k <k0ma@utam0k.jp>
```bash $ protoc --version libprotoc 3.12.4 $ make generate-protocols ``` Signed-off-by: utam0k <k0ma@utam0k.jp>
utam0k
force-pushed
the
oci-domainname
branch
from
6b72eb2
to
a49375c
Compare
|
@ManaSugi Thanks for your review. I updated, PTAL. |
|
This PR has been opened without with no activity for 180 days. Comment on the issue otherwise it will be closed in 7 days |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opencontainers/runtime-spec#1156
Signed-off-by: utam0k k0ma@utam0k.jp