use single source for go version

[grosser]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

• unify version that ci uses
• make life easier for anyone using a go version manager

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[karmada-bot]

Welcome @grosser! It looks like this is your first PR to karmada-io/karmada 🎉

[XiShanYongYe-Chang]

Hi @grosser, do you have any documentation on how to use the .go-version file?

[RainbowMango]

I'm also curious about how it works.
I couldn't find more information, except the asdf thing:
https://github.com/asdf-community/asdf-golang?tab=readme-ov-file#version-selection

[liangyuanpeng]

You still need to using it on the workflow, otherwise it will not working.

https://github.com/etcd-io/etcd/blob/547aa643e69d55328b203f40ccec50256b44158e/.github/workflows/build.yaml#L24-L28

      - id: goversion
        run: echo "goversion=$(cat .go-version)" >> "$GITHUB_OUTPUT"
      - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
        with:
          go-version: ${{ steps.goversion.outputs.goversion }}

[grosser]

trying with go-version-file that hopefully works 🤞

tools like go-env / asdf / mise can read this file to set the local go version
some of them can also read .go.mod, but asdf and mise refuse to read from it because of some rabbithole

[liangyuanpeng]

I can see that the .go-version is working .

[grosser]

👋 need a CI approval

[liangyuanpeng]

The karmada's maintainers will return from vacation tomorrow.

/lgtm

[liangyuanpeng]

I think it's need to squash the commit

[grosser]

squashed into single commit

if single commit is a requirement, making the PR template say it would speed up PRs

[grosser]

and need another approval @liangyuanpeng

[RainbowMango]

I haven't used mise before, but I just tried it out. I still don't know how the auto-switching works, and what its benefit is. Can you help to explain it a little bit?

[grosser]

auto-switching switches the go version when cd-ing into a directory according to the directories .go-version

[grosser]

I'm ok with either ... just want someone with merge permission to tell me what they would be willing to merge and will make adjustments accordingly.
Would also love to merge as is and create followup for adding to go.mod to move the discussion 🤷

[RainbowMango]

Thanks @grosser.

This PR consists of two parts actually as you mentioned in the PR description:

unify version that ci uses

Great thanks for bringing this discussion, really helpful!
This part is clear, that we can add the Go version to go.mod and let CI get the version from it.

make life easier for anyone using a go version manager

For this part, I'm evaluating all these go-version managers(mise, asdf, go-env) to figure out the following questions:

• Is the .go-version file a standard way that can be consumed by common go-version managers? Otherwise, consider a situation, where a developer uses another go-version manager which requires a different file, shall we introduce another go-version file?
• Can we put .go-version file to somewhere inside the repo(not in the root of repo)? There are already too many scattered files in the root directory.

[RainbowMango]

It seems both mise and asdf provided the auto-switching feature:

• For asdf: https://asdf-vm.com/manage/configuration.html#tool-versions
• mise: https://mise.jdx.dev/configuration.html#tool-versions

They both support .tool-versions, can we use this file?

[RainbowMango]

auto-switching switches the go version when cd-ing into a directory according to the directories .go-version

This feature is awesome by the way. Just tried it out.

[grosser]

why would we need .tool-versions, this repo only uses go right ?

[RainbowMango]

yeah, since .tool-versions can be consumed by both asdf and mise users.

I mean take go.mod as a single source of truth, and the .tool-versions dedicated to those go-version managers.

[liangyuanpeng]

I think @RainbowMango is mean we want to use go.mod for the project and CI, then .tool-versions to working for go-version managers.

There are two topic, the Part1 is go version for build & CI, Part2 is the file for people who using the go-version managers.

I can see common practice ( kubernetes/kind/etcd ) is that go mod is set to the language version, and .go-version uses the higher version for compilation and building.

But as @RainbowMango say, using go.mod to unify go versions in CI may be a direction, so maybe we can try to using go.mod for CI and .tool-versions to working go version manager.

auto-switching switches the go version when cd-ing into a directory according to the directories .go-version

would you like to try with .tool-versions ? ( I don't have try them )

[grosser]

asdf also supports .go-version, so can we avoid 1 level of indirection by using that instead of .tool-versions ?

[RainbowMango]

asdf also supports .go-version, so can we avoid 1 level of indirection by using that instead of .tool-versions ?

Thanks for the reminder. I didn't notice it. then I belive .go-version is better than .tool-versions.

[RainbowMango]

By the way, the actions/setup-go has been updated to v5 by #4756, you might need to rebase when making adjustments.

[grosser]

rebased + updated go.mod to have full version

... is this mergeable now or what still needs to change ?

[RainbowMango]

Looks good to me!
/lgtm

@liangyuanpeng Do you have further comments?

[grosser]

plz restart the 1 failed ci job, seems unrelated ...

[RainbowMango]

Done.
This reminds me to hurry up the #4637, after that we can restart the test by /retest command.

[grosser]

still 2 checks pending ... any idea how to get them to pass ?

[RainbowMango]

still 2 checks pending ... any idea how to get them to pass ?

All good now. Ready to move forward now.
/approve
@liangyuanpeng If you have any further comments, please continue...

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment