Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch macOS from firefox-bin to firefox #330

Merged
merged 1 commit into from Feb 5, 2024
Merged

Switch macOS from firefox-bin to firefox #330

merged 1 commit into from Feb 5, 2024

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jan 10, 2024 •
edited

Upstream:

Long story short:

  • Firefox has shipped both for a long time.
  • Firefox signs the binaries in a way that only firefox passes Apple's "hightened" security rules.
  • Firefox 121 adds support for Apple's Passkey feature and that raised the level of security rules it has to pass, thus making firefox-bin appear like an imposter. This means macOS terminates firefox-bin with the message Killed: 9.

Fixes #328.

@Krinkle
Switch macOS from firefox-bin to firefox
6918785 
Upstream:
* "firefox-bin is broken". https://bugzilla.mozilla.org/show_bug.cgi?id=1871447
* "remove firefox-bin". https://bugzilla.mozilla.org/show_bug.cgi?id=1873782

Long story short:
* Firefox has shipped both for a long time.
* Firefox signs it in a way that makes only `firefox` pass "hightened" security rules.
* Firefox 121 adds support for Apple's Passkey feature and that raised the level of security rules it has to pass.

Fixes #328.
whimboo
whimboo reviewed Jan 11, 2024
View reviewed changes
index.js Show resolved Hide resolved
mgol
mgol approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes the issue I reported in #328

@mgol
Copy link
Contributor

mgol commented Jan 16, 2024

Given the following deprecation notice:
https://github.com/karma-runner/karma-firefox-launcher/blob/a55a7f43fd8ecdce02fb9a558ed769381add8083/README.md#karma-firefox-launcher-is-deprecated-and-is-not-accepting-new-features-or-general-bug-fixes
I am not sure if we'll get this fix merged. 😕 From the linked note:

Critical security issues in Karma will still be triaged and fixed as necessary.

@tiagobento tiagobento mentioned this pull request Jan 16, 2024
Merged
@karendolan karendolan mentioned this pull request Jan 22, 2024
Closed
@mgol mgol mentioned this pull request Feb 3, 2024
Closed
@pmvald pmvald merged commit c190cd4 into karma-runner:master Feb 5, 2024
3 checks passed
@Krinkle Krinkle deleted the patch-2 branch February 5, 2024 18:19
@Krinkle
Copy link
Contributor Author

Krinkle commented Feb 5, 2024

@pmvald Thanks for merging this PR! Could you release this as well? Or are there other changes or steps we need to follow first? Let me know if I can help with anything.

@pmvald
Copy link
Member

pmvald commented Mar 3, 2024

The release is automatic. This PR did not follow PR naming guidelines and so it did not trigger release for a new version by semver. I'll merge a bunch of other PRs which hopefully trigger a release.

@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo left review comments

@mgol mgol mgol approved these changes

@pmvald pmvald pmvald approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot start Firefox (or FirefoxHeadless) 121 on macOS Sonoma 14.2.1 (23C71)
5 participants
@Krinkle @mgol @pmvald @karmarunnerbot @whimboo