Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node action engine to Node20 #564

Merged
merged 5 commits into from Aug 28, 2023
Merged

Update node action engine to Node20 #564

merged 5 commits into from Aug 28, 2023

Conversation

kachick
Copy link
Owner

@kachick kachick commented Aug 28, 2023

Closes #556

This PR merges several node20 updating codes from #556 but keeping minimum changes for now

So #549 will be done in another PR

kachick/action-typescript-template#387
actions/runner#2619 (comment)

@kachick kachick changed the title Node20 simple Update node action engine to Node20 Aug 28, 2023
@kachick kachick mentioned this pull request Aug 28, 2023
@kachick kachick marked this pull request as ready for review August 28, 2023 08:21
@kachick kachick merged commit 7cba696 into main Aug 28, 2023
12 checks passed
@kachick kachick deleted the node20-simple branch August 28, 2023 08:22
This was referenced Aug 28, 2023
@kachick kachick mentioned this pull request Sep 24, 2023
kachick added a commit to kachick/action-typescript-template that referenced this pull request Oct 5, 2023
kachick added a commit to kachick/action-typescript-template that referenced this pull request Oct 5, 2023
* Simply replaced to node20

kachick/wait-other-jobs#564

* `npm install --save-dev @tsconfig/strictest @tsconfig/node20`

* Refer upstream tsconfig again

This made failure in jest

* Update node20 and refine environments

See https://github.com/kachick/wait-other-jobs/pulls for more detail

- Update node20
- Replace jest with node18+ test runner
- Refer upstream tsconfig
- Replace ncc role with esbuild

* Update dist with added build task

* `npm uninstall @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint`

* Replace eslint with `deno lint`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant