Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Text.Encodings.Web dependency #998

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

martincostello
Copy link
Member

Fix package incorrectly being dependent on System.Text.Encodings.Web 9.0.1.

Fix package incorrectly being dependent on System.Text.Encodings.Web 9.0.1.
@martincostello martincostello added bug A defect in the code or documentation. dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Feb 5, 2025
@martincostello martincostello added this to the v5.1.0 milestone Feb 5, 2025
@Copilot Copilot bot review requested due to automatic review settings February 5, 2025 13:04
@martincostello martincostello requested a review from a team as a code owner February 5, 2025 13:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • Directory.Build.props: Language not supported
  • Directory.Packages.props: Language not supported
  • samples/SampleApp.Tests/SampleApp.Tests.csproj: Language not supported
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (cbf45be) to head (6e0c3cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          15       15           
  Lines         868      868           
  Branches      198      198           
=======================================
  Hits          862      862           
  Misses          4        4           
  Partials        2        2           
Flag Coverage Δ
linux 99.30% <ø> (ø)
macos 99.30% <ø> (ø)
windows 99.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Member Author

Fixed:

image

@martincostello martincostello merged commit 499e41e into main Feb 5, 2025
13 checks passed
@martincostello martincostello deleted the fix-reference-version branch February 5, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the code or documentation. dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant