Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.0, Notebook 5 mentions from contributor docs #15710

Merged
merged 3 commits into from Jan 30, 2024
Merged

Remove Python 3.0, Notebook 5 mentions from contributor docs #15710

merged 3 commits into from Jan 30, 2024

Conversation

JasonWeill
Copy link
Contributor

@JasonWeill JasonWeill commented Jan 29, 2024 •
edited

Removes a couple of references to obsolete, end-of-life software, from our contributor docs: Python 3.0, Notebook 5.

Also makes a couple of small copy edits to the rest of the section.

@JasonWeill
Update contributing.rst
df6e9f6 
Removes a couple of references to obsolete, end-of-life software
@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@JasonWeill
Update contributing.rst
18c837b 
Fixes intra-page link
@fcollonval fcollonval added this to the 4.0.x milestone Jan 30, 2024
fcollonval
fcollonval approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasonWeill

@krassowski
Copy link
Member

I think the header-license-fix is failing because this branch is far behind main, I will click "Update branch" button to confirm it passes on merge.

krassowski
krassowski approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JasonWeill!

@krassowski krassowski merged commit af8d902 into jupyterlab:main Jan 30, 2024
77 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jan 30, 2024
@JasonWeill @meeseeksmachine
Backport PR jupyterlab#15710: Removes Python 3.0, Notebook 5 mentions…
6831e8b 
… from contributor docs
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 30, 2024
Merged
krassowski pushed a commit that referenced this pull request Jan 30, 2024
@meeseeksmachine @JasonWeill
Backport PR #15710: Removes Python 3.0, Notebook 5 mentions from cont…
69079ec 
…ributor docs (#15715)

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
@krassowski krassowski changed the title Removes Python 3.0, Notebook 5 mentions from contributor docs Remove Python 3.0, Notebook 5 mentions from contributor docs Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees

@JasonWeill JasonWeill

Labels
documentation
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasonWeill @krassowski @fcollonval