New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jupyterlab downgrade issue on extension installation #15650
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
@fcollonval can you help me out here, I did not catch why we need to use constrain here over just a requirement? |
in this specific case we could use a requirement. But what we want to achieve is actually add the extension as requirement with some constraints on the dependencies. As stated in the documentation:
So using a constraint is more aligned with the intent here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sarthug99
@meeseeksdev please backport to 4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…sion installation
…llation (#15714) Co-authored-by: Sarthak Umarani <sarthakumarani99@gmail.com>
References
Fixes #15277
Code changes
Created a temporary constraint file using tempfile.NamedTemporaryFile. I obtained the current JupyterLab version and enforced it as a constraint. This constraint is then passed to the pip install command using the --constraint flag, so that any plugin installation is in line with the existing JupyterLab version.
User-facing changes
User won't face the issue of JupyterLab getting downgraded on installation of certain plugins, as was the case before.
Backwards-incompatible changes