Fix spurious "File Changed" dialogs using hash from jupyter-server v2.11.1+

[Wh1isper]

References

Fixes #7743
Fixes #11352

References PR: #15037

Upstream:

• Support get file(notebook) md5 jupyter-server/jupyter_server#1363
• Change md5 to hash and hash_algorithm, fix incompatibility jupyter-server/jupyter_server#1367

Code changes

Since jupyter server may provide hash in model, we compare hash for the file changes first.

Forgive me for being a TypeScript and front-end novice, more advice would be appreciated, thanks!

User-facing changes

N/A

Backwards-incompatible changes

N/A

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[krassowski]

Thank you for this PR! It looks good except for one condition which I am not sure about.

Would you consider also adding a test for this? I think it could be added along:

jupyterlab/packages/docregistry/test/context.spec.ts

Lines 85 to 108 in 6b498b4

	describe('#fileChanged', () => {
	it('should be emitted when the file is saved', async () => {
	const path = context.path;
	let called = false;
	context.fileChanged.connect((sender, args) => {
	expect(sender).toBe(context);
	expect(args.path).toBe(path);
	called = true;
	});
	await context.initialize(true);
	expect(called).toBe(true);
	});
	it('should not contain the file content attribute', async () => {
	let called = false;
	context.fileChanged.connect((sender, args) => {
	// @ts-expect-error content is omitted
	expect(args['content']).toBeUndefined();
	called = true;
	});
	await context.initialize(true);
	expect(called).toBe(true);
	});
	});

[Wh1isper]

I will add a test on this soon, thanks!

[Wh1isper]

I changed some logic about emit fileChanged and added hash and hash_algorithm in mock.

I have tested following situations manually:

• When hash is provided, fileChanged is not emitted.
• When hash is not provided, fileChanged is emitted because of timeStamp changed.

But I don't know how to reorganise the test cases to support both scenarios.

Feel free to give me more feed back, thanks!

[krassowski]

Thank you @Wh1isper!

I pushed a few more tests and tiny adjustments in the conditionals.

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️