Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #15479 on branch 4.0.x (Workaround/input box focus) #15563

Merged

Commits on Dec 26, 2023

  1. Backport PR jupyterlab#15479: Workaround/input box focus

    * Re-focus input after modifying model, keep input for 0.5s
    
    * Add a test case against the focus loss issue
    
    Tested that it fails on main reproducing the issue:
    
    ```
        - Expected  - 0
        + Received  + 8
    
          from time import sleep
          input()
          print('before sleep')
          sleep(0.1)
          print('after sleep')
        +
        +
        + x
        +
        +
        +
        +
        +
    ```
    
    * Give up on using animations and :has() solution due to FF bug
    
    https://bugzilla.mozilla.org/show_bug.cgi?id=1867893
    
    `:has()` is not only not yet officially supported but is hard to
    implement well so no wonder there are difficult invalidation bugs
    
    * More robust stdin test
    
    (cherry picked from commit 68be103)
    krassowski committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    216bf92 View commit details
    Browse the repository at this point in the history