Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #15443 on branch 4.0.x (Fix search coming back in notebook and editor) #15562

Merged

Commits on Dec 26, 2023

  1. Backport PR jupyterlab#15443: Fix search coming back in notebook and …

    …editor
    
    * a test case to illustrate issue jupyterlab#14871
    
    * cleanup unused code
    
    * rename outline into highlight as it sounds more proper
    
    * fix typo in variable name _unrenderedByHighligh → _unrenderedByHighlight
    
    * Fix search coming back in notebook and editor
    
    * Add missing return
    
    * Rename snapshots and limit screenshot to notebook area
    
    Remove no-op await locator line
    
    * Update Playwright Snapshots
    
    * Improve async test implementation to avoid early closing
    
    * Update Playwright Snapshots
    
    * Remove visual snapshots, use locator counts instead
    
    and revert spurious snapshot updates
    
    ---------
    
    Co-authored-by: Thierry Parmentelat <thierry.parmentelat@inria.fr>
    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    (cherry picked from commit 746ce2d)
    krassowski committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    c52f2c8 View commit details
    Browse the repository at this point in the history