Workaround focus leaving input box on consecutive submissions #15479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested that it fails on main reproducing the issue:
```
- Expected - 0
+ Received + 8
from time import sleep
input()
print('before sleep')
sleep(0.1)
print('after sleep')
+
+
+ x
+
+
+
+
+
```
https://bugzilla.mozilla.org/show_bug.cgi?id=1867893 `:has()` is not only not yet officially supported but is hard to implement well so no wonder there are difficult invalidation bugs
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:outputarea
tag:Testing
tag:CSS
|
@meeseeksdev please backport to 4.0.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
krassowski
changed the title
krassowski
added a commit
to krassowski/jupyterlab
that referenced
this pull request
Dec 26, 2023
* Re-focus input after modifying model, keep input for 0.5s
* Add a test case against the focus loss issue
Tested that it fails on main reproducing the issue:
```
- Expected - 0
+ Received + 8
from time import sleep
input()
print('before sleep')
sleep(0.1)
print('after sleep')
+
+
+ x
+
+
+
+
+
```
* Give up on using animations and :has() solution due to FF bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1867893
`:has()` is not only not yet officially supported but is hard to
implement well so no wonder there are difficult invalidation bugs
* More robust stdin test
(cherry picked from commit 68be103)
krassowski
added a commit
that referenced
this pull request
Dec 27, 2023
* Re-focus input after modifying model, keep input for 0.5s
* Add a test case against the focus loss issue
Tested that it fails on main reproducing the issue:
```
- Expected - 0
+ Received + 8
from time import sleep
input()
print('before sleep')
sleep(0.1)
print('after sleep')
+
+
+ x
+
+
+
+
+
```
* Give up on using animations and :has() solution due to FF bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1867893
`:has()` is not only not yet officially supported but is hard to
implement well so no wonder there are difficult invalidation bugs
* More robust stdin test
(cherry picked from commit 68be103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #12322
Code changes
User-facing changes
Users will be able to quickly send replies without the input box loosing focus and leading to the code editor being overwritten.
This is 99% solution - if the delay is over 0.5s it will fail.
Backwards-incompatible changes
None