Fix FormComponent showing error indicators in all fields when using a customValidate function
#15464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
This PR should be ready, is there anything else that I should do? |
krassowski
approved these changes
Dec 10, 2023
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Dec 12, 2023
…ators in all fields when using a `customValidate` function
krassowski
pushed a commit
that referenced
this pull request
Dec 12, 2023
…ll fields when using a `customValidate` function (#15522) Co-authored-by: Matthew Michilot <matthew.michilot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes: #15447
Code changes
Also check the length of
rawErrorssincerawErrorswill be an empty array rather thanundefinedwhen acustomValidatefunction is passed toFormComponent.