Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search coming back in notebook and editor #15443

Merged
merged 13 commits into from
Dec 13, 2023
Merged

Fix search coming back in notebook and editor #15443

merged 13 commits into from
Dec 13, 2023

Commits on Oct 11, 2023

  1. a test case to illustrate issue jupyterlab#14871

    @parmentelat
    parmentelat committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    84fad8f View commit details
    Browse the repository at this point in the history

  2. cleanup unused code

    @parmentelat
    parmentelat committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    24e6c34 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. rename outline into highlight as it sounds more proper

    @parmentelat
    parmentelat committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e6998f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. fix typo in variable name _unrenderedByHighligh → _unrenderedByHighlight

    @parmentelat
    parmentelat committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    a5e9a26 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into fix-search-reappering

    @krassowski
    krassowski committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4747a9c View commit details
    Browse the repository at this point in the history

  2. Fix search coming back in notebook and editor

    @krassowski
    krassowski committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    17b52c5 View commit details
    Browse the repository at this point in the history

  3. Add missing return

    @krassowski
    krassowski committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    12f5901 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge branch 'main' into fix-search-reappering

    @krassowski
    krassowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    323ee87 View commit details
    Browse the repository at this point in the history

  2. Rename snapshots and limit screenshot to notebook area 

    Remove no-op await locator line
    @krassowski
    krassowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d4a9894 View commit details
    Browse the repository at this point in the history

  3. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    4532738 View commit details
    Browse the repository at this point in the history

  4. Improve async test implementation to avoid early closing

    @krassowski
    krassowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a238736 View commit details
    Browse the repository at this point in the history

  5. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c64cc29 View commit details
    Browse the repository at this point in the history

  6. Remove visual snapshots, use locator counts instead 

    and revert spurious snapshot updates
    @krassowski
    krassowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    84e841b View commit details
    Browse the repository at this point in the history