-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic implementation to toggle the placeholder text #15321
base: main
Are you sure you want to change the base?
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Thanks for starting this. We cannot add a new toolbar button for every setting, this should be rewritten to be a setting in Notebook schema instead. Please do ask if you need pointers. |
Thank you for the feedback, @krassowski . I understand the concern about adding too many toolbar buttons. I'll work on moving this functionality to the Notebook schema as a setting. I'm relatively new to this, so I'd appreciate any pointers or guidance you can provide on how to best implement this in the Notebook schema. Thanks for your patience and support! |
A recent PR that implemented a new Notebook setting was #13944 - have a look at which files were modified in there to thread |
@navdeepgill14 are you still interested in working on this? |
References
Closes #15138
Code changes
User-facing changes
Backwards-incompatible changes
None. The changes introduced are compatible with the existing JupyterLab public APIs and do not break any existing functionality.