Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mermaid 10.6.0, marked 9.1.2, rjsf 5.13.2 #15302

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Bump mermaid 10.6.0, marked 9.1.2, rjsf 5.13.2 #15302

merged 6 commits into from
Oct 26, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 25, 2023 •
edited by krassowski

References

Fixes #15309

Code changes

  • update js deps
    • mermaid 10.6.0 for bug fixes, performance, and new xychart
    • marked 9.1.2 for bug fixes
    • rjsf 5.13.2 for bug fixes
    • ???
  • docs
    • disable custom JS keyboard navigation in pydata-sphinx-theme (also raises warning)
    • ???
  • ???

User-facing changes

  • large mermaid charts should render more reliably

Backwards-incompatible changes

  • n/a

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 4.1.0 milestone Oct 25, 2023
@bollwyvl bollwyvl marked this pull request as ready for review October 25, 2023 16:56
@bollwyvl
Copy link
Contributor Author

Welp, it ran good once: cd7348e 😅

@krassowski
Copy link
Member

disable custom JS keyboard navigation in pydata-sphinx-theme (also raises warning)

We will want to backport this one, might be slightly easier if it is in a separate PR.

@bollwyvl bollwyvl mentioned this pull request Oct 25, 2023
Closed
2 tasks
@bollwyvl
Copy link
Contributor Author

@krassowski backport up on #15304

@krassowski krassowski mentioned this pull request Oct 26, 2023
Closed
fcollonval
fcollonval reviewed Oct 26, 2023
View reviewed changes
docs/source/conf.py Outdated Show resolved Hide resolved
fcollonval
fcollonval approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl

CI failures are not related.

@krassowski krassowski merged commit bf6e4a8 into jupyterlab:main Oct 26, 2023
79 of 80 checks passed
@bollwyvl
Copy link
Contributor Author

Thanks all 🤗

@bollwyvl bollwyvl deleted the bump-mermaid-10.6.0 branch October 26, 2023 21:13
@bollwyvl bollwyvl mentioned this pull request Oct 27, 2023
Merged
2 tasks
@fcollonval fcollonval mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@bollwyvl bollwyvl

Labels
maintenance pkg:celltags pkg:codemirror pkg:completer pkg:lsp pkg:notebook pkg:settingeditor pkg:settingregistry pkg:ui-components
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

CI failure: linux docs - due to warning emitted by sphinx template
3 participants
@bollwyvl @krassowski @fcollonval