Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create JupyterLab 3.4.4 accessibility statement #14856

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

isabela-pf
Copy link
Contributor

This PR adds an accessibility statement for JupyterLab 3.4.4 to the JupyterLab documentation. This is the same statement as has been on jupyter/accessibility documentation for some time now, barring formatting changes made to make this fit within the existing JupyterLab docs.

Please note that the version number the review applies to is not the most current release. Since many users do not update versions immediately, I've been asked to contribute this as it will still be relevant to our community (users and contributors and decision makers).

As always, review is welcome. I'll answer questions to the best of my ability, so thanks in advance for giving this a bit of your time. 🌻

References

There is no issue on JupyterLab singularly for adding an accessibility statement.

#14396's request for user-facing accessibility documentation is the closest. #9399's review is also referenced, and many of the issues persisted even though this statement was made for a more recent version.

Code changes

This adds a new page to the Getting Started documentation and adds an accessibility section to the Getting Started table of contents.

User-facing changes

Users in the JupyterLab documentation will find a new section of Getting Started and a new page with a JupyterLab accessibility statement.

Backwards-incompatible changes

There are no backwards incompatible changes I am aware of.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isabela-pf

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@fcollonval fcollonval merged commit 816d4bb into jupyterlab:main Aug 2, 2023
76 of 79 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 2, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 816d4bb471f043ab621635b2633eaf330be0bc72
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14856: Create JupyterLab 3.4.4 accessibility statement'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-14856-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #14856 on branch 3.6.x (Create JupyterLab 3.4.4 accessibility statement)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval pushed a commit that referenced this pull request Aug 3, 2023
…14906)

Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
@isabela-pf
Copy link
Contributor Author

Thank you @fcollonval and @krassowski! 🌻

fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Aug 11, 2023
fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Aug 11, 2023
fcollonval added a commit that referenced this pull request Aug 13, 2023
…14958)

Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants